Feature #681848: Editor can't create owned base - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Actions

Send by e-mail Copy link

Feature #681848

open

Editor can't create owned base

Added by Jacob Nevins about 6 years ago. Updated 6 months ago.

Status:

New

Priority:

Normal

Assignee:

Category:

General

Sprint/Milestone:

3.0.8

Start date:

Due date:

% Done:

Estimated time:

Description

(originally from bug #25119)

The editor doesn't have a way to edit the extras_owner of a tile directly.

This means scenario authors can't easily create owned buoys, for instance -- they will likely start unowned, unless the tile happens to already have a non-NULL (invisible) extras_owner.

Fixing this would need network protocol support.

It's not completely impossible to add owned extras without hacking the savefile; you can do it by hand with Lua:

/lua cmd edit.create_base(find.tile(43,57) , "Buoy", find.player(0))

Actions

Copy link

Updated by Jacob Nevins about 6 years ago

Blocks Task #656467: S3_0 network protocol freeze (npf) added

Actions

Copy link

Updated by Jacob Nevins about 6 years ago

I think we should fix this for 3.0. (Really it's a gap in 2.6, but it's too late for that branch.)

I don't have immediate plans to work on it, though.

I think it's still the case on all branches that ownership is only meaningful for bases; so in the editor UI, it should be sufficient to add a nation control to the base editing UI (no need for road/special), I think.

Actions

Copy link

Updated by Marko Lindqvist about 6 years ago

Jacob Nevins wrote:

in the editor UI, it should be sufficient to add a nation control to the base editing UI (no need for road/special), I think.

Since all the extras in a tile share same extra owner, it should not be controlled by editors of individual extra classes, but should be edited as tile property.

Actions

Copy link

Updated by Jacob Nevins about 6 years ago

Hm, that's true.

It'll make editing annoying if you have to go to the tile dialog for every owned base, though. It's probably reasonable to set the extra owner to player X when creating an ownable base as player X.

Should we make a special effort to clear the extra owner when the last ownable base is removed? Otherwise there'll be hidden state that could show up when the global observer creates a buoy or whatever.

Actions

Copy link