Feature #683532: citizens_graphic / citizens_graphic_alt don't do anything - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Actions

Send by e-mail Copy link

Feature #683532

closed

citizens_graphic / citizens_graphic_alt don't do anything

Added by Jacob Nevins over 7 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Low

Assignee:

Marko Lindqvist

Category:

Client

Sprint/Milestone:

3.2.0

Start date:

Due date:

% Done:

Estimated time:

Description

We've been carrying ruleset support for specifying citizens_graphic / citizens_graphic_alt on a per-city-style basis since 2003 (commit:c70b3c37e1), but it's never been wired up to the tileset, so it doesn't do anything.

It would probably be quite easy to make this work; get_citizen_sprite() looks like it has the relevant information. It would probably need a few redraws to ensure citizen graphics are redrawn when the style changes.

Files

0029-Support-city-style-specific-citizen-sprites.patch (22.4 KB) 0029-Support-city-style-specific-citizen-sprites.patch

Marko Lindqvist, 2022-02-01 06:18 PM

Related issues

Actions

Copy link

Updated by Marko Lindqvist almost 7 years ago

Sprint/Milestone set to 3.0.0

Actions

Copy link

Updated by Marko Lindqvist almost 7 years ago

Blocks Task #656466: S3_0 datafile format freeze (d3f) added

Actions

Copy link

Updated by Marko Lindqvist over 6 years ago

The format is rather limited. Should we extend the format, or should we derive all the tag names from the single entry currently given?
There's just one entry. We should have tileset-defined number of alternative sprites for each of the happiness types (content, happy, unhappy, angry).

Actions

Copy link

Updated by Marko Lindqvist almost 6 years ago

Blocks Task #673656: S3_1 datafile format freeze (d3f) added

Actions

Copy link

Updated by Marko Lindqvist almost 6 years ago

Sprint/Milestone changed from 3.0.0 to 3.1.0

Actions

Copy link

Updated by Marko Lindqvist almost 6 years ago

Blocks deleted (Task #656466: S3_0 datafile format freeze (d3f))

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Preparatory patch: https://osdn.net/projects/freeciv/ticket/43582

This seems to be getting more complicated than originally assumed. I'm inclined to postpone this again (to 3.2). The above patch has already been targeted to 3.2 on that assumption -> also it needs to be ported if we are to keep 3.1 target for this.
There's no kind of regression in this in 3.1, so that shouldn't block postponing.

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

https://osdn.net/projects/freeciv/ticket/43650 is about dropping the _alt part of this. There's already a number of fallbacks, and adding another one would just cause confusion of what's the order they are applied, as well as making the implementation much more ugly.

Actions

Copy link