Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #745596

Make it possible to switch between JSON and native on a connection basis

Added by Louis Moureaux over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The goal is to have the server support both native and JSON clients at the same time.

Patch on top of master. I can make patches for other branches too.

connection-json-native.patch (19.5 KB) connection-json-native.patch Louis Moureaux, 2018-04-08 11:57 AM

History

#1 Updated by Marko Lindqvist over 4 years ago

Louis Moureaux wrote:

Patch on top of master. I can make patches for other branches too.

These features have been planned for master only.

About the patch: Shouldn't json_mode be initialized (to FALSE) also when FREECIV_JSON_CONNECTION is not set?

#2 Updated by Marko Lindqvist over 4 years ago

  • Category set to General
  • Status changed from New to In Progress
  • Sprint/Milestone set to 3.1.0

#3 Updated by Louis Moureaux over 4 years ago

Marko Lindqvist wrote:

About the patch: Shouldn't json_mode be initialized (to FALSE) also when FREECIV_JSON_CONNECTION is not set?

I think it's safer not to have it at all when JSON mode isn't compiled in, just like json_packet.

#4 Updated by Marko Lindqvist over 4 years ago

  • Status changed from In Progress to Resolved

#5 Updated by Marko Lindqvist over 4 years ago

  • Assignee set to Marko Lindqvist

Just a hint for future submissions: Preferred form of patch files is one created by 'git format-patch ...' so that there's already a proper commit message and some other metadata.

#6 Updated by Marko Lindqvist over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF