Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #758964

closed

Missing extrastyles in supplied tilesets

Added by Jacob Nevins over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Art
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Many of our tilesets define sprites for extras, but don't mention them in extrastyles. base.output, base.airstrip, and base.buoy are common cases.

It looks like there is independent fallback for alternate extrastyles and the actual extra graphics. So rulesets like civ2civ3 have been getting away by falling back to from "base.outpost" to "base.fortress" for extrastyle, while continuing to use "base.outpost" actual graphics. Fortunately, the extrastyle has ended up matching the graphics.

However, a ruleset like 'alien' has "base.force_fortress" falling back to "base.outpost". If an attempt is made to use a standard tileset with 'alien', it bombs with

0: No extrastyle for "base.force_fortress" or "base.outpost".

This can be provoked by doing

freeciv-gtk3 -t isophex -r alien

and starting a game, and declining any prompt to change to 'alio'.

(It doesn't make much sense to allow differential fallback for extrastyle and the actual extra graphics, since the two are coupled. Probably we should somehow enforce that the matching extra style and extra graphics are used. Don't know how practical that is, particularly in the face of tilesets pulling in bits of other tilesets that may define sprites that the first tileset is not interested in.)


Files


Related issues

Blocks Freeciv - Bug #758989: Tilesets: too easy for extrastyle and defined extra graphics not to matchClosedJacob Nevins

Actions
Actions #1

Updated by Jacob Nevins over 5 years ago

I've done a fairly thorough inventory of the things that were on S2_6. I didn't thoroughly inventory things that were different on later branches (notably, I didn't check that all the extrastyles for resources matched up on S3_0+).

Actions #2

Updated by Jacob Nevins over 5 years ago

  • Related to Bug #758989: Tilesets: too easy for extrastyle and defined extra graphics not to match added
Actions #3

Updated by Jacob Nevins over 5 years ago

Probably we should somehow enforce that the matching extra style and extra graphics are used.

-> bug #758989

Actions #4

Updated by Jacob Nevins over 5 years ago

  • Related to deleted (Bug #758989: Tilesets: too easy for extrastyle and defined extra graphics not to match)
Actions #5

Updated by Jacob Nevins over 5 years ago

  • Blocks Bug #758989: Tilesets: too easy for extrastyle and defined extra graphics not to match added
Actions #6

Updated by Jacob Nevins over 5 years ago

notably, I didn't check that all the extrastyles for resources matched up on S3_0+

I have now, with the aid of bug #758989 to make mistakes more obvious.

Actions #7

Updated by Jacob Nevins over 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF