Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Send by e-mail

Feature #802523

Refactor fcdb calls to be more flexible

Added by Zoltán Žarkov over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Sprint/Milestone:
3.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I want to change the login workflow to something that allows mechanisms other than unsalted md5 passwords. I propose changing user_load to user_exists and user_verify lua calls, where user_verify checks if the password is correct. To maintain compatibility, an md5sum function is exposed to the fcdb lua environment, and the default database.lua file calls it when checking password against database.

0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.2 KB) 0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch S3_0 Zoltán Žarkov, 2019-02-13 05:05 PM
0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.2 KB) 0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch master Zoltán Žarkov, 2019-02-13 05:06 PM
0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.3 KB) 0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch S3_0 Zoltán Žarkov, 2019-02-14 06:08 AM
0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.3 KB) 0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch master Zoltán Žarkov, 2019-02-14 06:08 AM
0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.2 KB) 0001-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch master Zoltán Žarkov, 2019-02-15 05:23 PM
0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch (10.2 KB) 0002-Refactor-fcdb-login-flow-to-allow-better-authenticat.patch S3_0 Zoltán Žarkov, 2019-02-15 05:23 PM

Related issues

Related to Freeciv - Task #656466: S3_0 datafile format freeze (d3f)Closed2019-10-05

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#2 Updated by Zoltán Žarkov over 3 years ago

  • Related to Task #656466: S3_0 datafile format freeze (d3f) added

#3 Updated by Marko Lindqvist over 3 years ago

Reviewing S3_0 patch: Documentation comment in script_fcdb.c shows that new user_save would now take just one parameter, but it still takes two parameters like before, right?

#5 Updated by Marko Lindqvist over 3 years ago

  • Category set to Server
  • Status changed from New to Resolved

#6 Updated by Marko Lindqvist over 3 years ago

  • Status changed from Resolved to In Progress

On S3_0 build without enabling auth:
src/server/scripting/script_fcdb.c:194:12: error: ‘md5sum’ defined but not used [-Werror=unused-function]
static int md5sum(lua_State *L)

This build has been configured as:
$ ./config.status --config
'--enable-debug' '--enable-client=gtk3.22' '--enable-fcmp=gtk3'

#8 Updated by Marko Lindqvist over 3 years ago

  • Status changed from In Progress to Resolved

#9 Updated by Marko Lindqvist over 3 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist
Send by e-mail

Also available in: Atom PDF