HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Feature #819758
closedGold support for unhomed units
0%
Description
unhomed_uk_gold_options
that is a combination of several flags:
- "StartingFree" - starting number of units is free
- "ShareFreeSlots" - all unused unit support slots in all cities are useable by unhomed units.
- "AllFree" - no upkeep at all, current and default behaviour.
- "NoFreeGov" - gold upkeep is paid for the unhomed ones with their unit type gold value even if the government has factor 0.
- "All2gold" - any types of upkeep are converted to gold for unhomed units.
Also, we can have effect and/or game parameter and/or Lua variable (in case we give some civs extra free units) for a basic number of free nation-supported units.
Files
Related issues
Updated by Marko Lindqvist almost 3 years ago
- Sprint/Milestone changed from 3.1.0 to 3.2.0
I haven't thought about this, but linking to S3_2-d3f so that it will be considered in time for 3.2.
Updated by Marko Lindqvist almost 3 years ago
- Blocks Task #939772: S3_2 datafile format freeze (d3f) added
Updated by Marko Lindqvist over 2 years ago
I've started to write a patch related to this ticket, but got sidetracked by other things that came up while doing so (but one might consider some of those as dependencies for this anyway).
Just the overall idea was different from the suggestions here that instead of making handling of current upkeep values more complicated (subject to more modificators and flags) I were looking in to adding "national level upkeep" as a completely separate field for units in the units.ruleset.
Updated by Marko Lindqvist about 2 years ago
- File 0047-Add-support-for-gold-upkeep-for-homeless-units.patch 0047-Add-support-for-gold-upkeep-for-homeless-units.patch added
- Status changed from New to Resolved
- Assignee set to Marko Lindqvist
Well, after several iterations (internal to my own my own development machine) it's better to just ignore earlier comments, and take a fresh look at this implementation.
- Unhomed units have their gold upkeep based on the same effects as homed ones. The main change this patch brings is that when previously units were iterated for upkeep from the list of their supporting city, now the iteration is over the list of player's owned units, and thus including homeless units (not in the list of any city)
- This is functionality is never available when gold_upkeep_style is "City" for obvious conflict between the settings (can't have city to pay upkeep for units that have no city)
- In this initial patch compatibility mode for older rules is controlled simply by global boolean "homeless_gold_upkeep" ruleset setting. Old behavior is kept as the default for now. I hope that better mechanisms for these emerge during 3.2 cycle already. I think it's better to have this in its current form already, than to wait that dependencies of better mechanisms get implemented (mainly meaning that requirements checking unit homelessness should work for all unit upkeep effects)
Updated by Marko Lindqvist about 2 years ago
osdn ticket for this: https://osdn.net/projects/freeciv/ticket/46020
Updated by Marko Lindqvist about 2 years ago
- Status changed from Resolved to Closed