Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #827472

Editor copy-paste functionality optimization

Added by Alexandro Ignatiev about 3 years ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Just so it does: any units from the original tile are pasted to the source tile 3 times. (Also, properties other than unit type are not copied, but this is pdobably another ticket.) 3.1 has the same bug. Really can't understand where it comes from.

0001-Fix-copying-of-units-and-cities-in-editor-some-optim.patch (11.2 KB) 0001-Fix-copying-of-units-and-cities-in-editor-some-optim.patch patch for edtor copy-paste tool Alexandro Ignatiev, 2019-07-19 05:19 PM

History

#1 Updated by Alexandro Ignatiev about 3 years ago

Mystery solved. Just we should add break; after lines 1547 and 1555 in client/editor.c. Also, a city is not placed because we have not set the virtual tile as its center and tile_city() at l. 1570 returns NULL.

#2 Updated by Alexandro Ignatiev about 3 years ago

Patch for 3.1, likely should go to 2.6 and 3.0 as well (2.5 does not have these bugs).

#3 Updated by Marko Lindqvist over 2 years ago

  • Category set to Client
  • Sprint/Milestone changed from 3.0.0-beta1 to 2.6.2

#4 Updated by Marko Lindqvist over 2 years ago

  • Status changed from New to In Progress

The patch here is 99% things other than fixing the reported bug. While the bug should be fixed in stable branches, the big code changes for a minor optimization (in non-critical code path) should not go there.

As the big patch is here now, I think it's the bugs that should be split to a new ticket(s) and leave this ticket for the optimization.

#5 Updated by Marko Lindqvist over 2 years ago

  • Subject changed from Copy-paste in editing mode triples units to Editor copy-paste functionality optimization
  • Sprint/Milestone changed from 2.6.2 to 3.0.0

Marko Lindqvist wrote:

I think it's the bugs that should be split to a new ticket(s) and leave this ticket for the optimization.

Tripled units -> Bug #850947

#6 Updated by Marko Lindqvist 6 months ago

  • Sprint/Milestone changed from 3.0.0 to 3.0.1

#7 Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone changed from 3.0.1 to 3.2.0

Marko Lindqvist wrote:

The patch here is 99% things other than fixing the reported bug. While the bug should be fixed in stable branches, the big code changes for a minor optimization (in non-critical code path) should not go there.

As the big patch is here now, I think it's the bugs that should be split to a new ticket(s) and leave this ticket for the optimization.

As this ticket is the optimization one -> this is the one that does not belong to stable branch.

#8 Updated by Marko Lindqvist about 2 months ago

  • Status changed from In Progress to New

Also available in: Atom PDF