Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #838867

Task #774803: Emscripten clients for web.

Add SDL2 Emscripten client to autotools build

Added by Zoltán Žarkov almost 3 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)

Description

This patch builds under the original travis ci, and is the bare minimum for a successful build of wasm sdl2 client. Other patches will be needed to make it actually runnable- I did not want to make this one unmanageably large.


Subtasks

Feature #871637: emscripten: Disable SDL2 configure checksClosedMarko Lindqvist

Actions

Related issues

Blocks Freeciv - Feature #839110: Add Qt Emscripten client to autotools buildNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Feature #847674: Emscripten beach head.Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocked by Freeciv - Feature #869884: emscripten: Disable zlib configure checkClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Zoltán Žarkov almost 3 years ago

  • File 0001-Update-the-build-system-and-add-macros-for-SDL2-Emsc.patch added

#2 Updated by Zoltán Žarkov almost 3 years ago

  • File deleted (0001-Update-the-build-system-and-add-macros-for-SDL2-Emsc.patch)

#6 Updated by Zoltán Žarkov almost 3 years ago

  • Sprint/Milestone set to 2.6.1

#7 Updated by Zoltán Žarkov almost 3 years ago

  • Blocks Feature #839110: Add Qt Emscripten client to autotools build added

#8 Updated by Zoltán Žarkov almost 3 years ago

  • Assignee set to Sveinung Kvilhaugsvik

May I request your review for this?

#9 Updated by Sveinung Kvilhaugsvik over 2 years ago

  • Assignee deleted (Sveinung Kvilhaugsvik)

Thank you for the reminder, Zoltán. I'm unfortunately not competent to review this patch. I am however interested in learning. If I find time to learn before someone else reviews your patch I'll have another look.

Potentially stupid question: Why is (parts of) the SDL 2 client the bare minimum? Wouldn't libfreeciv have been smaller and easier? Is it more difficult to test a C library compiled to wasm by calling it from JavaScript than I think it is?

#10 Updated by Zoltán Žarkov over 2 years ago

  • Assignee set to Sveinung Kvilhaugsvik

I made it for the entire client because that's what we have already working :)

#11 Updated by Zoltán Žarkov over 2 years ago

  • Assignee deleted (Sveinung Kvilhaugsvik)

Sorry, didn't mean to reassign.

#12 Updated by Sveinung Kvilhaugsvik over 2 years ago

#13 Updated by Jacob Nevins over 2 years ago

  • Sprint/Milestone changed from 2.6.1 to 2.6.2

Is this really intended to be a goal for S2_6?

#14 Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone changed from 2.6.2 to 3.0.0

Jacob Nevins wrote:

Is this really intended to be a goal for S2_6?

Some other related patches have already been targeted to S3_0.

#15 Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone changed from 3.0.0 to 3.1.0

#16 Updated by Marko Lindqvist over 2 years ago

It would help if someone rebased what is still needed of this patch on top of current HEAD + Feature #871336 (+ Feature #869884 if it's needed)

#17 Updated by Zoltán Žarkov over 2 years ago

  • Blocked by Feature #869884: emscripten: Disable zlib configure check added

Also available in: Atom PDF