Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Actions
Send by e-mail Copy link

Feature #839110

open

Task #774803: Emscripten clients for web.

Add Qt Emscripten client to autotools build

Added by Zoltán Žarkov over 5 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
3.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)

Description

I've made the build system changes to allow the Qt Emscripten work to be upstreamed.

Files

Download all files
0002-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch (9.83 KB) 0002-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch master Zoltán Žarkov, 2019-09-29 10:59 PM
0003-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch (10.3 KB) 0003-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch S3_0 Zoltán Žarkov, 2019-09-29 11:07 PM
0004-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch (9.75 KB) 0004-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch S2_6 Zoltán Žarkov, 2019-09-29 11:08 PM
0003-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch (9.78 KB) 0003-Update-the-build-system-and-add-macros-for-Qt-Emscri.patch S3_0 Zoltán Žarkov, 2019-09-29 11:15 PM

Sub-issues 1 (1 open — 0 closed)

Feature #873419: Consolidate Qt configure flagsNew

Actions

Related issues

Blocked by Freeciv - Feature #838867: Add SDL2 Emscripten client to autotools buildNew

Actions
Actions
Copy link
 #3

Updated by Zoltán Žarkov over 5 years ago

  • Blocked by Feature #838867: Add SDL2 Emscripten client to autotools build added
Actions
Copy link
 #5

Updated by Jacob Nevins about 5 years ago

  • Sprint/Milestone changed from 2.6.1 to 2.6.2
Actions
Copy link
 #6

Updated by Jacob Nevins about 5 years ago

  • Sprint/Milestone changed from 2.6.2 to 3.0.0
Actions
Copy link
 #7

Updated by Marko Lindqvist over 4 years ago

  • Sprint/Milestone changed from 3.0.0 to 3.1.0
Actions
Copy link
 #8

Updated by Marko Lindqvist over 4 years ago

Is a new separate --with-qt5 configure option really needed? Why aren't existing --with-qt5-includes & --with-qt5-libs & MOCCMD sufficient?
If the new option is really needed, it should be implemented first in a separate ticket.

Actions
Copy link
 #9

Updated by Zoltán Žarkov over 4 years ago

Not necessary to add --with-qt5 option here, but adding logic to remove -fPIC from CXXFLAGS is needed.

Actions
Copy link
 #10

Updated by Zoltán Žarkov over 4 years ago

No, I was wrong, we also have to link against -L$with_qt5/plugins/platforms. The plugins directory is outside $qt5_lib.

Actions
Copy link
 #11

Updated by Marko Lindqvist over 4 years ago

Zoltán Žarkov wrote:

No, I was wrong, we also have to link against -L$with_qt5/plugins/platforms. The plugins directory is outside $qt5_lib.

Then the question is should this be, for maximum flexibility, third --with-qt5-plugins option to be used alongside --with-qt5-includes and --with-qt5-libs, or just one option to set the root directory as in the existing patch?

Actions
Copy link
 #12

Updated by Zoltán Žarkov over 4 years ago

The best option will be specifying qmake path (maybe --with-qmake) and using qmake -query to return individual directories as needed. Includes and libs may not be the same subdirectories of the qt root in normal cases.

On my distro-installed qt:
QT_INSTALL_HEADERS:/usr/include/x86_64-linux-gnu/qt5
QT_INSTALL_LIBS:/usr/lib/x86_64-linux-gnu

A wasm install:
QT_INSTALL_HEADERS:/qt5/emscripten-wasm-install/include
QT_INSTALL_LIBS:/qt5/emscripten-wasm-install/lib

Actions
Send by e-mail Copy link

Also available in: Atom PDF