Freeciv

AI code only- not exposed to client code yet.

The S3_0 patch above applies cleanly to S2_6- might as well apply it there too.

Zoltán Žarkov wrote:

The S3_0 patch above applies cleanly to S2_6- might as well apply it there too.

I don't think there will be any users for this in the stable branches.

- Function should be named not that to look like minimum_food_surplus in a generic case, but only in the special case that we want to grow as fast as possible. min_food_surplus_for_fast_growth()?
- Function definition beginning curly brace to a line of its own
- if (!ptile) should be followed by a block despite being just one line
- I think min_turns can end 0 in some special cases, leading to division by zero on the last line

- Renamed
- Fixed style
- Added comment explaining why min_turns will never be 0

From an autogame with this (and bunch of other patches I hope do not affect this) I get a lot of:

1: in auto_arrange_workers() [../../../src/server/cityturn.c::408]: assertion 'cmr->found_a_valid' failed.

At its present state patch should not affect worker placement at all, as we should never execute the new code, but I assume unitialized max_growth parameter leads it to execute it anyway. Second issue is that it then fails when executed.

- Handle max_growth in init, cmp places for cm_parameter struct
- Return negative value from min_surplus function. If a city is unavoidably starving, use this setting to just maximize food output rather than returning a 0 goal that causes cma to not find solution.

Autogame works better now.