Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #850022

New action "Transport Embark"

Added by Sveinung Kvilhaugsvik over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

0001-New-action-Transport-Embark.patch (58.7 KB) 0001-New-action-Transport-Embark.patch Sveinung Kvilhaugsvik, 2019-11-30 06:05 PM

Related issues

Related to Freeciv - Feature #848637: New action "Transport Board"Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Sveinung Kvilhaugsvik over 2 years ago

#2 Updated by Sveinung Kvilhaugsvik over 2 years ago

  • Status changed from Resolved to Closed

#3 Updated by Sveinung Kvilhaugsvik over 2 years ago

#4 Updated by Marko Lindqvist over 1 year ago

This would be the next commit to port to freeciv/freeciv.web. Any ideas how that should be done?

As far as I know web-client has no idea of native tiles, but has always just sent movement requests to server to block, or to convert to transport embarking. With this new action, the client would need to know when to request it.
For earlier unload / load actions that has not been a problem. Even with Disembark we do know that if we are currently transported, then any move would require Disembarking. Reverse is not true for - even when we are not currently transported, it's only a rare case when a move is meant to be Embarking.

#5 Updated by Sveinung Kvilhaugsvik over 1 year ago

Marko Lindqvist wrote:

just sent movement requests to server to block, or to convert to transport embarking.

Won't that just result in the action selection dialog popping up with embark as an alternative?

the client would need to know when to request it.

You could send a background request to the server and hook into handle_unit_actions() as its first user. (Remember to mark the request as background by setting disturb_player)

#6 Updated by Marko Lindqvist over 1 year ago

Sveinung Kvilhaugsvik wrote:

Marko Lindqvist wrote:

just sent movement requests to server to block, or to convert to transport embarking.

Won't that just result in the action selection dialog popping up with embark as an alternative?

Ok. So I just have to try to do the server update to that commit and see if it works, instead of worrying beforehand.

Also available in: Atom PDF