Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #850504

savegame: store action id in orders as vector of numbers

Added by Sveinung Kvilhaugsvik over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

needs savegamecompat for 3.0 and previous 3.1 save games

tmp.patch (13.8 KB) tmp.patch Sveinung Kvilhaugsvik, 2019-12-13 09:43 AM
0001-savegame-store-order-action-id-as-a-number.patch (22.5 KB) 0001-savegame-store-order-action-id-as-a-number.patch Sveinung Kvilhaugsvik, 2019-12-16 05:28 AM
0001-savegame-store-order-action-id-as-a-number-v2.patch (22.5 KB) 0001-savegame-store-order-action-id-as-a-number-v2.patch Sveinung Kvilhaugsvik, 2019-12-16 07:49 AM

History

#1 Updated by Sveinung Kvilhaugsvik over 2 years ago

  • File tmp.patch tmp.patch added
  • Category set to Server
  • Status changed from New to In Progress
  • Assignee set to Sveinung Kvilhaugsvik

Untested work in progress patch without savegame compatibility.

#4 Updated by Sveinung Kvilhaugsvik over 2 years ago

v2: fix spelling of field name in devel savegame compat.

#5 Updated by Sveinung Kvilhaugsvik over 2 years ago

  • Status changed from Resolved to Closed

#6 Updated by Marko Lindqvist over 2 years ago

Sorry to ask this late, but have you checked that this does not break savegame2 save loading? Those savegames too go through compat conversion function, but are then handled by savegame2.c. In the compat conversion functions 'format_class' tells if it's going to be handled by savegame2.c or savegame3.c.

#7 Updated by Sveinung Kvilhaugsvik over 2 years ago

Marko Lindqvist wrote:

Sorry to ask this late, but have you checked that this does not break savegame2 save loading? Those savegames too go through compat conversion function, but are then handled by savegame2.c. In the compat conversion functions 'format_class' tells if it's going to be handled by savegame2.c or savegame3.c.

savegame2 save games doesn't have an unit order action_list to upgrade. They should be skipped. (if ((action_unitstr = secfile_...) I don't think I tested loading a savegame2 with orders just to be sure.

Thank you for the 'format_class' tip.

Also available in: Atom PDF