HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #856551
(B)uild city doesn't work in qt client (3.0.92-dev (15fea6a008))
0%
Description
The help seen inside the qt client sez:
B: go to and (B)uild city on target tile (settler units)
but pressing shift-B doesn't do anything.
Go-to-and build city from the menu does work.
History
#1
Updated by Jacob Nevins over 2 years ago
- Sprint/Milestone set to 3.1.0
I think I see the same on master. (S2_6 is fine.)
It looks like there is still code intended to make this work by default. From shortcuts.cpp:
{SC_GOBUILDCITY, Qt::Key_B, Qt::AllButtons, Qt::ShiftModifier, _("Go And Build City") },
Maybe something to do with action generalisation / Go to and... menu?
#2
Updated by Marko Lindqvist over 2 years ago
What does the menu display as the shortcut key?
There's a problem that Qt-client shortcuts saved by S2_6/S3_0 mess up shortcuts in master, and vice versa. You may be seeing it here. Currently when (default) shortcuts are saved in S2_6/S3_0, master shows, e.g., 'F' as the key for Building a City.
#3
Updated by Marko Lindqvist over 1 year ago
- File 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch added
- Category set to gui-qt
- Status changed from New to Resolved
Marko Lindqvist wrote:
There's a problem that Qt-client shortcuts saved by S2_6/S3_0 mess up shortcuts in master, and vice versa.
Attached fix is not optimal , but it's an improvement. It makes shortcut storage to be per version, starting from 3.1 (current master). I plan to push this as an improvement over current situation.
#4
Updated by Marko Lindqvist over 1 year ago
- File 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch added
- Minor coding style improvement
#5
Updated by Marko Lindqvist over 1 year ago
- File 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch 0037-Qt-Save-shortcuts-for-different-versions-of-freeciv-.patch added
- Added code comment about the change. It should prevent us from thinking that it would be a good idea to combine version specific shortcuts (back) to one set of shortcuts in the future.
#6
Updated by Marko Lindqvist over 1 year ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist