Bug #857352: Help for Barracks needs some tweaking (master, civ2civ3) - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Actions

Send by e-mail Copy link

Bug #857352

closed

Help for Barracks needs some tweaking (master, civ2civ3)

Added by Chippo Elder over 3 years ago. Updated 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Rulesets

Sprint/Milestone:

Start date:

Due date:

% Done:

Estimated time:

Description

The help currently reads:

"With a Barracks, each new land unit built in a city will automatically have Veteran status, which means that its attack and defense strengths are increased by 50%.

Also, damaged land units which stay in town for one full turn without moving are completely restored."

Engineers don't start with Veteran status. That could be fixed by saying "new MILITARY land unit". But Engineers DO get completely restored after staying in town for a full turn. I can't think of a succinct to say what the case is...

Actions

Copy link

Updated by Chippo Elder over 3 years ago

I should have said in the Subject and the body that this is about Barracks II, 'cos Gunpowder is a prerequisite for Explosives.

Actions

Copy link

Updated by Chippo Elder over 3 years ago

And the same is true for Diplomats - don't get veteran, do get healed.

Actions

Copy link

Updated by Marko Lindqvist over 2 years ago

Category set to Rulesets

Actions

Copy link

Updated by Marko Lindqvist about 2 years ago

Chippo Elder wrote:

I should have said in the Subject and the body that this is about Barracks II, 'cos Gunpowder is a prerequisite for Explosives.

One may get Engineers by bribery without knowing Gunpowder themselves.

Actions

Copy link

Updated by Marko Lindqvist about 2 years ago

Chippo Elder wrote:

But Engineers DO get completely restored after staying in town for a full turn.

Reading the ruleset they shouldn't. They belong to "Small Land" class and that class gets HP_Regen effect only in Fortress.

Actions

Copy link

Updated by David Fernandez (bard) over 1 year ago

Marko Lindqvist wrote:

Reading the ruleset they shouldn't. They belong to "Small Land" class and that class gets HP_Regen effect only in Fortress.

Marko is right, currently "Small Land" units are not fully restored by barracks, they just get restored a hardcoded amount of HPs: 33% + 10% (if not moving nor attacking for 1 turn) + 10% (if fortified), that use to restore the unit in 1 turn too unless heavly damaged.

But I agree Chippo that some fix is needed. Changing the help to say "new MILITARY land unit" would be more accurate, but the same would be true for classic rules.

I think the confusing part in civ2civ3 is that land in this case includes "Land" and "Big Land" classes, but not "Small Land".
My suggestion would be to include them all, so "Small Land" units do are fully restored by barracks, and the helptext could be changed to:

helptext = _("\
With a Barracks, each new MILITARY land unit built in a city will\
automatically have Veteran status, which means that its attack and\
defense strengths are increased by 50%.\
"), _("\
Also, damaged land units which stay in town for one full turn\
without moving are completely restored.\
")

I'll create the patch.

Actions

Copy link

Updated by Marko Lindqvist 12 months ago

David Fernandez (bard) wrote:

I'll create the patch.

Ping

Actions

Copy link

Updated by David Fernandez (bard) 2 months ago

Sorry, I have not been around here for long time, and I forgot about this patch.
It is in my ToDo list in case I'm able to make patches for this ruleset again.

Actions

Copy link