Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. *Read more...*

Bug #857432

open

New team (from civil war) remains 'Never met' after a meeting (2.6.1+)

Added by Chippo Elder almost 3 years ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

If you load the attached savegame (2.6.1+ (modified b31d594a73)), you'll see in Messages that the Karens had a civil war and there's a new gang called the Burmese. Nations tells us that they were put into their own new team and that we've Never met. Since we have Marco Polo's Embassy, we have a meeting with them. They refuse to enter into a cease-fire with us, which is another bug (AIs have to grant cease-fire on first meeting (but not subsequent meetings, which is why it's important to secure one first time)). Cancel the meeting, and back on the Nations tab it tells you that you've still 'Never met'.

It all resolves itself next turn, but it's confusing for new (and old) players, so should be fixed.


Files

great-library.sav.bz2 (227 KB) great-library.sav.bz2 Chippo Elder, 2020-01-27 07:51 AM
ContactsToNewPlayers.patch (3.58 KB) ContactsToNewPlayers.patch Marko Lindqvist, 2022-06-16 08:51 AM
Actions #1

Updated by Chippo Elder almost 3 years ago

Both bugs also seen in 2.6.2+ (f3042e6322).

Actions #2

Updated by Marko Lindqvist over 2 years ago

Chippo Elder wrote:

AIs have to grant cease-fire on first meeting

Why?

Actions #3

Updated by Marko Lindqvist over 1 year ago

  • Category set to Server
  • Sprint/Milestone set to 2.6.4
Actions #4

Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.4 to 2.6.5
Actions #5

Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.5 to 2.6.6
Actions #6

Updated by Marko Lindqvist 12 months ago

  • Sprint/Milestone changed from 2.6.6 to 3.0.1
Actions #7

Updated by Marko Lindqvist 8 months ago

  • Sprint/Milestone changed from 3.0.1 to 3.0.2
Actions #8

Updated by Marko Lindqvist 6 months ago

  • Sprint/Milestone changed from 3.0.2 to 3.0.3
Actions #9

Updated by Marko Lindqvist 6 months ago

Chippo Elder wrote:

It all resolves itself next turn

It's actually in the beginning of the player's own phase, not on change of entire turn.

Creation of entirely new player is such an important special case, that I think we should handle like this ticket requests. The risk here is that we open can of worms by not sticking to the definition that contacts effects go to effect on phase start - it's a clear rule, whereas sometimes enabling contacts mid-turn and sometimes not (any contacts effect with requirements changing mid-turn) is not.

Actions #10

Updated by Marko Lindqvist 6 months ago

Chippo Elder wrote:

Since we have Marco Polo's Embassy, we have a meeting with them.

I can reproduce this in (EOL) S2_6, but not in later branches. I think it's a bug in S2_6 (and earlier) implementation that you can have a meeting with someone with you have no contact actually established (even though Marco Polo)

As the things stand in S3_0 and later, you don't get the contact with the new player until beginning of your next phase, but neither can you meet them like you had the contact.
What do people think; do we want to change that so that contact is provided immediately on player creation?

Actions #11

Updated by Marko Lindqvist 6 months ago

Attaching what I already had implemented when testing/investigating this.

Actions #12

Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone changed from 3.0.3 to 3.0.4
Actions #13

Updated by Marko Lindqvist about 2 months ago

  • Sprint/Milestone changed from 3.0.4 to 3.1.0

Marko Lindqvist wrote in #note-10:

What do people think; do we want to change that so that contact is provided immediately on player creation?

Even if we do, I don't think we do in a release branch -> retargeting to 3.1 (maybe should go all the way to master - to have this ruleset configurable)

Also available in: Atom PDF