Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #857724

Mid-turn Governor (CMA) changes not saved when game is saved manually

Added by Chippo Elder over 2 years ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I set my Governor setting for my cities and took a screenshot (attached). I saved the game (attached). I quit freeciv. Start freeciv again, load the savegame and look at the Governor settings and see that they have changed. Screenshots attached.

governor-before.png (8.52 KB) governor-before.png Chippo Elder, 2020-01-29 08:42 AM
governor-reset.sav.bz2 (328 KB) governor-reset.sav.bz2 Chippo Elder, 2020-01-29 08:43 AM
governor-after-gtk.png (4.74 KB) governor-after-gtk.png Chippo Elder, 2020-01-29 08:43 AM
governor-after-qt.png (9.3 KB) governor-after-qt.png Chippo Elder, 2020-01-29 08:43 AM
freeciv-client-rc-2.6 (13.5 KB) freeciv-client-rc-2.6 Chippo Elder, 2020-01-29 09:42 AM
250
250
250

Related issues

Blocks Freeciv - Task #939772: S3_2 datafile format freeze (d3f)New

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins over 2 years ago

There's a few things that could be going on here. I don't know which without seeing your client settings file.
  • Governor presets in the city report are matched by value (that is, each city stores only numeric settings, and the client tries to match these to a named preset for display). If there are multiple presets with the same values, perhaps which one wins can change on a fresh client start. (I can see that in your savegame, two of your cities match the default "Prefer production" preset and one matches "Prefer food", matching your 'after' screenshot.) (Arguably the bug is that multiple presets with the same values should be prevented.)
  • Governor presets are saved in freeciv-client-rc (client settings) file, not the savegame. If you changed the presets, and client settings weren't saved before you quit (by you or automatically), then your preset changes will be lost. (I don't think there's a bug here, since the default is to save automatically on quit.)
  • Finally, quitting mid-turn is known to lose any changes to cities' governor settings, due to the way the governor works. See gna bug #18850 . That's a (design) bug. I can't tell if it bit you. (I thought it was documented, but I don't see it in online help or README.governor.)

#2 Updated by Chippo Elder over 2 years ago

Jacob Nevins wrote:

See gna bug #18850 . That's a (design) bug. I can't tell if it bit you.

That seems to be the bug. So, we can reject this ticket, I think.

I attached my client settings just in case.

#3 Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone set to 3.1.0

We had the gna bug, but I don't think we have had hrm ticket before this.

Current design had been chosen on the assumption that there would be more users for the general client attributes design. There never has been second user for that. We can keep the attributes design around, but we should change governor settings to not use them. The data they have has been unchanged for a very long time, so it's unlikely that there would be major compatibility problems with dedicated design (network protocol, savefile format) over versions.

#4 Updated by Marko Lindqvist over 2 years ago

  • Blocks Task #673656: S3_1 datafile format freeze (d3f) added

#5 Updated by Jacob Nevins over 2 years ago

  • Subject changed from Save/load cycle resets the Governor settings (2.6.1+) to Mid-turn Governor (CMA) changes not saved when game is saved manually

#6 Updated by Chippo Elder over 2 years ago

I had to search around (very little) to find out what a CMA was. If CMA is preferred over Governor, shouldn't we change the guis to say CMA instead of Governor in that Cities column and in the City dialog?

#7 Updated by Marko Lindqvist over 2 years ago

Chippo Elder wrote:

I had to search around (very little) to find out what a CMA was. If CMA is preferred over Governor, shouldn't we change the guis to say CMA instead of Governor in that Cities column and in the City dialog?

Governor is a (more user-friendly) synonym for CMA.

#8 Updated by Jacob Nevins over 2 years ago

shouldn't we change the guis to say CMA

We went the other way a mere 13 years ago...

(I just put "CMA" in the subject to match the Gna ticket, and make clear to people reading code that this is about that specific bit of Freeciv, not other bits that people think of as the "governor" like what the code calls the building advisor. Wasn't meant as a criticism, "Governor" is fine.)

#9 Updated by Marko Lindqvist 5 months ago

Marko Lindqvist wrote:

We can keep the attributes design around, but we should change governor settings to not use them.

That's certainly too big a redesign to enter S3_1 any more. So the overall ticket is going to get postponed. I am, however, still trying to find a way to somehow mitigate the problem even in 3.1.

#10 Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone changed from 3.1.0 to 3.2.0

Marko Lindqvist wrote:

So the overall ticket is going to get postponed.

Doing that now.

still trying to find a way to somehow mitigate the problem even in 3.1.

Mitigation in https://osdn.net/projects/freeciv/ticket/44304 can actually be applied to even older branches.

#11 Updated by Marko Lindqvist 4 months ago

  • Blocks Task #939772: S3_2 datafile format freeze (d3f) added

#12 Updated by Marko Lindqvist 4 months ago

  • Blocks deleted (Task #673656: S3_1 datafile format freeze (d3f))

Also available in: Atom PDF