Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #858206

Turn AI defaults into regular server settings

Added by Jacob Nevins over 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Currently, the 'variant2' modpack's variant2.serv file looks like this:

rulesetdir              variant2

cheating

; Explicitly create 6 threaded AI players
create "" threaded
create "" threaded
create "" threaded
create "" threaded
create "" threaded
create "" threaded

I assume the intent is that the default AIs for the ruleset are 'cheating' and 'threaded' ones. (And perhaps it would ideally want all AIs to be like that, including barbarians and so on.)

If there were regular server settings that controlled a newly created AI's defaults, then these commands in the .serv file would be unnecessary (and perhaps we could abolish ruleset selection by .serv file -- see #858204 for why that's desirable).

There would still be a place for the current special server AI level commands /cheating and so on -- as well as changing the default for new AIs, they modify all existing ones. And that's a useful thing for the client AI selection to do.

(Gna patch #3321 suggested making the AI module type a server setting, but not for this reason. It points out that there's no way to control the AI module for civil war players, barbarians, and so on; this would help with that too.)

0043-Add-aitype-server-setting.patch (5.22 KB) 0043-Add-aitype-server-setting.patch master Marko Lindqvist, 2022-03-16 08:05 PM
0030-Add-aitype-server-setting.patch (5.21 KB) 0030-Add-aitype-server-setting.patch S3_1 Marko Lindqvist, 2022-03-16 08:05 PM

Related issues

Related to Freeciv - Bug #858204: Qt/Gtk clients don't always keep ruleset selection combo box in sync with server rulesetBlocked

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Task #939772: S3_2 datafile format freeze (d3f)New

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins over 2 years ago

  • Blocks Task #673656: S3_1 datafile format freeze (d3f) added

#2 Updated by Jacob Nevins over 2 years ago

  • Related to Bug #858204: Qt/Gtk clients don't always keep ruleset selection combo box in sync with server ruleset added

#3 Updated by Marko Lindqvist over 2 years ago

Note that the variant2 version you are looking at sets just 6 AIs to use 'threaded' module, and leaves others to use default 'classic' module (aifill is something like 20)

#4 Updated by Marko Lindqvist 5 months ago

  • Status changed from New to In Progress
  • Assignee set to Marko Lindqvist

AI level part split to -> https://osdn.net/projects/freeciv/ticket/44105

Reserving this ticket for AI type part.

#5 Updated by Marko Lindqvist 5 months ago

Patches that work at least in the easy case. More testing is needed for how they interact when the setting gets loaded from a savegame or game.ruleset.

#6 Updated by Marko Lindqvist 5 months ago

Patches depend on https://osdn.net/projects/freeciv/ticket/43759 ( on macro GEN_STRING_NRS )

#7 Updated by Marko Lindqvist 5 months ago

Marko Lindqvist wrote:

More testing is needed for how they interact when the setting gets loaded from a savegame or game.ruleset.

There are just too many corner-cases for me to feel comfortable with pushing this to S3_1 at this point. We've lacked this feature for several versions already, maybe we postpone it just once more (the difference to previous ones being that now we have the patch to push to the new development branch, in time)

#8 Updated by Marko Lindqvist 5 months ago

  • Sprint/Milestone changed from 3.1.0 to 3.2.0

Marko Lindqvist wrote:

There are just too many corner-cases for me to feel comfortable with pushing this to S3_1 at this point. We've lacked this feature for several versions already, maybe we postpone it just once more (the difference to previous ones being that now we have the patch to push to the new development branch, in time)

No comments so far, so I'm retargeting this to 3.2 now. That decision can still be reverted later, if someone really feels it should.

#9 Updated by Marko Lindqvist 5 months ago

  • Blocks Task #939772: S3_2 datafile format freeze (d3f) added

#10 Updated by Marko Lindqvist 5 months ago

  • Blocks deleted (Task #673656: S3_1 datafile format freeze (d3f))

#11 Updated by Marko Lindqvist 5 months ago

  • Status changed from Approved to Closed

Also available in: Atom PDF