Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Actions
Send by e-mail Copy link

Feature #858238

closed

Requirement type to check if city's current owner is the original owner

Added by Marko Lindqvist almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
General
Sprint/Milestone:
3.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Split from Feature #857904 requested by Lexxie L.

Add a requirement type to check if city is currently owned by its original owner.

I think this should be implemented as a "CityStatus" requirement type. Initially (this ticket) it could take just one value; "OwnedByOriginal". While "OriginalOwner" might sound better value name, I'd reserve that for another requirement type that would check if specific nation has built the city.

Files

0021-Add-requirement-type-CityStatus.patch (13.9 KB) 0021-Add-requirement-type-CityStatus.patch Marko Lindqvist, 2020-04-18 01:57 AM
Actions
Copy link
 #2

Updated by Marko Lindqvist over 4 years ago

Patch attached.

This is one of the requirement types (with the only current value OwnedByOriginal) where client does not have enough information to know if it's true or not, so avoid using it where client's view matters.

Actions
Copy link
 #3

Updated by Marko Lindqvist over 4 years ago

Sveinung Kvilhaugsvik wrote:

See also gna patch #4718 https://web.archive.org/web/20170307072854/http://gna.org/patch/?4718

-> Feature #870141

Actions
Copy link
 #4

Updated by Marko Lindqvist over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist
Actions
Copy link
 #5

Updated by Lexxie L over 4 years ago

both the CityStatus and MinForeignPct have been tested and work FABULOUSLY! Brilliant. Thank you soooo much!!!!!!

By combining these two features with the "Age" req, I was able to successfully test a hypothetic case where:

Great Wall makes a city wall iff:
(City Age > 4) && (controlled by original owner || foreign population below x%)

Absolutely amazing, I am grateful and so pleased.

Combining these together and with other things is going to really do so much, we just have to get awareness of it publicised a little more.

One thing though, I pulled my hair for an hour until I figured out you can't use "0" for "MinForeignPct". You have to use "1", which is fine since pop 100 cities aren't too common! ;~) ❤️❤️

Actions
Send by e-mail Copy link

Also available in: Atom PDF