Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #869884

emscripten: Disable zlib configure check

Added by Marko Lindqvist over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Split from Feature #847674. Disable zlib configure check when configuring for emscripten.

Changes compared to Feature #847674 implementation:
- Be conservative, and only consider build an emscripten one if value of the variable is explicit "yes"


Related issues

Related to Freeciv - Feature #847674: Emscripten beach head.Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Feature #838867: Add SDL2 Emscripten client to autotools buildNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#2 Updated by Marko Lindqvist over 2 years ago

#3 Updated by Marko Lindqvist over 2 years ago

  • Status changed from Resolved to In Progress

Should set CFLAGS "-s USE_ZLIB=1" instead

#4 Updated by Marko Lindqvist over 2 years ago

Marko Lindqvist wrote:

Should set CFLAGS "-s USE_ZLIB=1" instead

Done in attached version.

#5 Updated by Marko Lindqvist over 2 years ago

Now the build is going through even without this patch. I assume the explanation to be that once we disabled libcurl check that was performed by pkg-config, include/lib paths are no longer polluted by host system paths that earlier made zlib test to fail.
As such, I don't know if this patch should be pushed or not. It might be wrong thing to do, and if it's not needed even as a workaround...

#6 Updated by Zoltán Žarkov over 2 years ago

This patch is still needed for emscripten builds.

#7 Updated by Zoltán Žarkov over 2 years ago

  • Blocks Feature #838867: Add SDL2 Emscripten client to autotools build added

#8 Updated by Marko Lindqvist over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF