Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #870579

closed

Remove useless "*StartUnit" roles

Added by Alexandro Ignatiev about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Rulesets
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Actually, only the first "*StartUnit" role has any game meaning. Abundance of the roles in supplied units.ruleset files spawned the belief that they are used by the AI; they are not and are not going to be, that's why starting roles were separated from game ones in the first place. Only So, remove the non-first specifications of the roles from all the rulesets.
(Side note for further tickets: why at all do the starting letters need some associated roles hard to remember? There could be just starting_unit_letter = "w" parameter. Currently, the only non-starting function that cares starting units, give_midgame_initial_units, relies on just 'k' letter. Also, we can't now give separate but optable out kings for nations like it's done in CivIII.)

Actions #1

Updated by Marko Lindqvist about 4 years ago

I think they make a difference depending on what techs player knows, i.e., when 'techlevel' server setting > 0.

Actions #2

Updated by Marko Lindqvist about 4 years ago

But you are right that those roles should be reviewed, and quite possibly limited to just one unit with a given role in the supplied rulesets. The history of the assigned roles is that when "*StartUnit" roles were separated from other roles and flags, they were blindly given to any unit with the base role or flag to not make any behavior change in that point. They have not been carefully thought.

Actions #3

Updated by Alexandro Ignatiev about 4 years ago

Yes, 'techlevel' is what I've missed. Actually, I have never started at a level allowing Feudalism or Magnetism (earliest classic ruleset techs that change something here), but a scenario may grant some higher era start. So maybe we really can't delete some flags in published versions (but e.g. Archers don't obsolete Warriors while having the same starting role and obsoleted by the same unit, so the redundant ones do exist).

Actions #4

Updated by Marko Lindqvist over 3 years ago

  • Sprint/Milestone changed from 2.6.3 to 2.6.4
Actions #5

Updated by Marko Lindqvist about 3 years ago

  • Sprint/Milestone changed from 2.6.4 to 2.6.5
Actions #6

Updated by Marko Lindqvist almost 3 years ago

  • Sprint/Milestone changed from 2.6.5 to 2.6.6
Actions #7

Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone changed from 2.6.6 to 3.0.1
Actions #8

Updated by Marko Lindqvist about 2 years ago

  • Sprint/Milestone changed from 3.0.1 to 3.0.2
Actions #9

Updated by Marko Lindqvist almost 2 years ago

  • Sprint/Milestone changed from 3.0.2 to 3.0.3
Actions #10

Updated by Marko Lindqvist almost 2 years ago

  • Category set to Rulesets
  • Sprint/Milestone changed from 3.0.3 to 3.0.4
Actions #11

Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 3.0.4 to 3.0.5

The main reason this ticket has not gone forward is that going through all rulesets in all branches is a bit big task to start when you would have just a short moment available. So maybe we turn this to a meta-ticket in 3.0.5 cycle, and go forward just one ruleset / ticket at a time.

Actions #14

Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 3.0.5 to 3.1.0

Subtickets already targeted to 3.1, so changing this one too.

Actions #15

Updated by Marko Lindqvist over 1 year ago

  • Assignee set to Marko Lindqvist

I don't think we are going to touch "compatiblity" rulesets civ1/civ2, so the current two child tickets are all we need. Right?

Going to close this one when the latter child gets closed.

Actions #16

Updated by Alexandro Ignatiev over 1 year ago

Marko Lindqvist wrote in #note-15:

I don't think we are going to touch "compatiblity" rulesets civ1/civ2, so the current two child tickets are all we need. Right?

Well, in a ruleset with tech tree allowing any holes there is, theoretically, an option for almost any starting unit types to be relevant in a scenario, right? Then we can let them be.

Actions #17

Updated by Marko Lindqvist over 1 year ago

  • Status changed from New to Closed

Also available in: Atom PDF