Bug #872573: civ2civ3: Ecclesiastical Palace documentation claim that it's fully blown second capital - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187

Actions

Send by e-mail Copy link

Bug #872573

closed

civ2civ3: Ecclesiastical Palace documentation claim that it's fully blown second capital

Added by Marko Lindqvist almost 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Documentation

Sprint/Milestone:

2.6.2.1

Start date:

Due date:

% Done:

Estimated time:

Description

civ2civ3 Ecclesiastical Palace is a Gov_Center, not a Capital_City. This means it will affect corruption and waste, but not to have other effects of an Capital. Yet its documentation list all the effects of an capital.
For master, where ruleset format will make it possible, the course of action will be to implement it as a fully blown secondary capital. That will happen in Feature #872572.
This ticket is about correcting the documentation in stable branches.

Files

Download all files

0013-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch (1.77 KB) 0013-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch		Marko Lindqvist, 2020-05-09 09:55 PM
0001-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch (1.33 KB) 0001-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch	S2_6_2	Marko Lindqvist, 2020-11-16 01:45 AM
0014-civ2civ3-Again-document-Ecclesiastical-Palace-to-pre.patch (1.24 KB) 0014-civ2civ3-Again-document-Ecclesiastical-Palace-to-pre.patch	S3_0, S2_6	Marko Lindqvist, 2020-11-16 01:54 AM

Related issues

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

File 0013-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch 0013-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch added
Status changed from In Progress to Resolved

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Related to Feature #872572: civ2civ3: Make Ecclesiastical Palace a secondary capital added

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Related to Feature #871681: Fix inability to properly harness Gov_Center effect in important cases. added

Actions

Copy link

Updated by Marko Lindqvist almost 3 years ago

Status changed from Resolved to Closed
Assignee set to Marko Lindqvist

Actions

Copy link

Updated by Anonymous over 2 years ago

Is removing "cannot be incited to revolt" right, though? As far as I can tell, it still prevents inciting a revolt, same as a Palace:

[actionenabler_incite_city]
action = "Incite City" 
actor_reqs    = ...
target_reqs  =
    { "type",   "name", "range", "present" 
      ...
      "Building", "Palace", "City", FALSE
      "Building", "Ecclesiastical Palace", "City", FALSE
      "Building", "Mausoleum of Mausolos", "Player", FALSE
    }

https://github.com/freeciv/freeciv/blob/S2_6/data/civ2civ3/game.ruleset#L397

Actions

Copy link

Updated by Marko Lindqvist over 2 years ago

Status changed from Closed to In Progress

Actions

Copy link

Updated by Marko Lindqvist over 2 years ago

File 0001-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch 0001-civ2civ3-Document-Ecclesiastical-Palace-as-not-quite.patch added

Ilkka Virta wrote:

Is removing "cannot be incited to revolt" right, though? As far as I can tell, it still prevents inciting a revolt

Updated patch for S2_6_2 where no commit has been pushed yet. S2_6 and S3_0 where the original commit has already been pushed will need this as additional fix.

Actions

Copy link