Freeciv

Still don't know how to submit patches, or I would. Sorry...

1. if off, keeps everything identical to classic mechanics (except the bug is fixed of course)
2. if set, then cities who are airlift-enabled will have their incoming airlift capacity augmented, proportionate to the population of their city, with the ratio being set by airliftdestdivisor (ALDD). e.g., if ALDD==1, a size 20 city would get 20 airlifts; if ALDD==2, it would get 10 airlifts, if ALDD=10, it would get 2 airlifts, etc.

Regarding feature #2, this solves an age-old very serious problem: airlift capacity of 1 being used up by either an incoming or outgoing airlift, it's much too limiting for the transportational issues on large multiplayer maps. But infinite capacity creates an OP situation of massive armies too easily teleporting to battle fronts, breaking any kind of balanced game of tactical integrity.

Apologies that the patched files also include changes to FCW client, one can simply ignore all the .js and .css files and take the .c and .h files.

Note: this patch has been running smoothly without issues for almost a year on FCW. It's great, we're never looking back!

link to patch:
https://github.com/Lexxie9952/fcw.org-server/commit/d53a97abf22e73b2fa27dde25fd4c1684260b27c#diff-70c24e5f6943fadaf1270c9b513ea650R690

Lexxie L wrote:

Still don't know how to submit patches

Yeah, it seems nobody has managed to update http://www.freeciv.org/wiki/How_to_Contribute since we migrated to git. I'll try to find time.

Meanwhile 'git help format-patch' might help you a bit.

In stable branches one could try workaround of not using unlimited airlift, but to give very high value for the airlift effect. That should limit airlift between Airports only while allowing a lot of airlifts. The same capacity applies both to source and destination, so can't make src limited & destination unlimited that way.

Marko Lindqvist wrote:

-> we should build ruleset controlled support for both in master

Suggestion: Move Airlift (per city) to the ruleset as a counter. (See Feature #859061 and Feature #859052) Require at least one in the action enablers for "Airlift Unit". Rulesets can replace it with "Take Offs" and "Landings" counters, "Take Offs" and "Can Land At All" counters etc. ("Landings" would be decreased on a landing, "Can Land At All" would not.) I do have more details for this suggestion written down somewhere.

ok there are rulesets who want some kind of airliftdestdivisor that makes capacity not static but earned by having a legitimate population correlating to more infrastructure, so i hope we don't abandon and punish the people who see and fix the problem again, by making them less compatible and in more tech debt

Sveinung Kvilhaugsvik wrote:

Marko Lindqvist wrote:

-> we should build ruleset controlled support for both in master

Suggestion: Move Airlift (per city) to the ruleset as a counter.

That sounds like a right to way to implement it, but will the counters work finish in time for 3.1?

Marko Lindqvist wrote:

Sveinung Kvilhaugsvik wrote:

Marko Lindqvist wrote:

-> we should build ruleset controlled support for both in master

Suggestion: Move Airlift (per city) to the ruleset as a counter.

That sounds like a right to way to implement it, but will the counters work finish in time for 3.1?

Counters won't be implemented for 3.1, so we need some other solution for this, or we need to postpone it.

Lexxie L wrote:

ok there are rulesets who want some kind of airliftdestdivisor that makes capacity not static but earned by having a legitimate population correlating to more infrastructure, so i hope we don't abandon and punish the people who see and fix the problem again, by making them less compatible and in more tech debt

It's not static even at the moment. You can adjust the airlift capacity by having multiple Airlift effects with different requirements. Don't know if one can create exactly what you want that way, though.

Marko Lindqvist wrote:

My proposal for a patch attached. It adds ruleset entries airlift_from_always_enabled and airlift_to_always_enabled to control this.

I like your proposal. Should be easy to transform into counters after 3.1.