HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
action: store action result in a separate field
Fake generalized actions and actions with an escape and a non escape variant have the same result. All the differences between them are defined by hard coded action data and by the ruleset. Checking action result by action id for those means a lot of duplicate code.
Add the field result to the action struct and network packet. Its data type is currently gen_action. I plan to make the gen_action enum about action results as a part of the work on generalized actions.
Pick one gen_action value as the result number for each group of actions that shares the same result. Make ction_has_result() assert that the value checked for actually is a result.
Replace multiple calls to action_has_result() that checks for multiple actions that has the same result with a single call that checks for the result alone.
#4 Updated by Sveinung Kvilhaugsvik about 2 years ago
- File 0010-action-store-action-result-in-a-separate-field.patch 0010-action-store-action-result-in-a-separate-field.patch added
v2: Remove TODO comment. Things may move along faster than expected.