Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #880321

Qt requires C++11 but we don't ask for it

Added by Sveinung Kvilhaugsvik about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

A C++ compiler may support C++11 but default to an older version.

Ask for C++11 when compiling C++ code. All our C++ code uses Qt. All Qt versions supported in 3.1 requires C++11.


Related issues

Related to Freeciv - Feature #880503: Update ax_cxx_compile_stdcxx.m4 (or remove serial)Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Feature #880335: Travis CI: build the Qt client on OS XClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist about 2 years ago

Any implementation of this should be careful not to downgrade to C++11 when the compiler default is e.g. C++14.

#3 Updated by Sveinung Kvilhaugsvik about 2 years ago

Marko Lindqvist wrote:

Any implementation of this should be careful not to downgrade to C++11 when the compiler default is e.g. C++14.

Any pointers to where I can start looking to check the current solution?

#4 Updated by Sveinung Kvilhaugsvik about 2 years ago

#5 Updated by Sveinung Kvilhaugsvik about 2 years ago

v2: non mandatory.

Marko Lindqvist wrote:

Any implementation of this should be careful not to downgrade to C++11 when the compiler default is e.g. C++14.

Looks suspicious. I see at least one unnecessary CXX='g++ -std=gnu++11' in config.log

#6 Updated by Sveinung Kvilhaugsvik about 2 years ago

v3: downgrade to a version that doesn't downgrade to C++11 when the compiler default is e.g. C++14

(Serial should be removed to avoid auto upgrades or the macro should be updated to a new upstream version with the functionality added back in a follow up patch.)

#7 Updated by Sveinung Kvilhaugsvik about 2 years ago

  • Related to Feature #880503: Update ax_cxx_compile_stdcxx.m4 (or remove serial) added

#8 Updated by Sveinung Kvilhaugsvik about 2 years ago

  • Status changed from Resolved to Closed

I forgot to mention that OS X would fail to build any Freeciv Qt programs before this patch. The error message made it look like the Qt install, not the C++ compiler, was the problem.

Also available in: Atom PDF