HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Client tries to load unit into enemy one instead of attacking it
Bug in logic of
request_move_unit_direction() in client/control.c: if the destination tile is non-native, the client calls
request_transport() and does anything else only if it fails. But this function in client/*/transportdlg.c checks only if there a unit type on the tile capable of transporting the unit, not if the unit actually can load into anything on the tile. For certain AttackNonNative units this situation leads to attempt boarding enemy ships instead of attacking them. Noticed by Wahazar
Updated by Alexandro Ignatiev over 3 years ago
could_unit_load already checks free place in the transport, and allied players we already have tested... But the other checks make some sense. (Btw, do I see recursively transported units of allies of my ally who are not my allies?..)
Updated by Marko Lindqvist over 3 years ago
I wonder if the check against non-allied tile should be added to transporter_for_unit_at() -> could_unit_load(). It already does transport tile checking to make sure that un-embarkable transport is in a city or native base.
Then the transportdlg code would only need to add check for not finding best_transport with transporter_for_unit_at().
Am I missing something?
Updated by Marko Lindqvist over 1 year ago
- Status changed from New to Closed
- Assignee set to Marko Lindqvist
Alexandro Ignatiev wrote:
Marko Lindqvist wrote:
Can Alexandro have a look how all this works in current branches?
Could not reproduce the bug in 3.0. Likely, it's gone.