HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187
Bug #881350
closed
Client tries to load unit into enemy one instead of attacking it
0%
Description
Bug in logic ofrequest_move_unit_direction() in client/control.c: if the destination tile is non-native, the client calls request_transport() and does anything else only if it fails. But this function in client/*/transportdlg.c checks only if there a unit type on the tile capable of transporting the unit, not if the unit actually can load into anything on the tile. For certain AttackNonNative units this situation leads to attempt boarding enemy ships instead of attacking them. Noticed by Wahazar
Files
Updated by Alexandro Ignatiev over 2 years ago
A patch that should resolve it, at least works for 2.6 gtk3(.22) and qt
Updated by Alexandro Ignatiev over 2 years ago
umm the could_unit_load already checks free place in the transport, and allied players we already have tested... But the other checks make some sense. (Btw, do I see recursively transported units of allies of my ally who are not my allies?..)
Updated by Alexandro Ignatiev over 2 years ago
The simpler patch (for v.2.6), most of could_... logic is rarely different from can_..., keep current possibilities.
Updated by Marko Lindqvist over 2 years ago
I wonder if the check against non-allied tile should be added to transporter_for_unit_at() -> could_unit_load(). It already does transport tile checking to make sure that un-embarkable transport is in a city or native base.
Then the transportdlg code would only need to add check for not finding best_transport with transporter_for_unit_at().
Am I missing something?
Updated by Marko Lindqvist about 2 years ago
- Sprint/Milestone changed from 2.6.3 to 2.6.4
Updated by Marko Lindqvist about 2 years ago
In later branches action enablers for boarding and attacking may have changed the situation. Can Sveinung have a look of this issue in general?
Updated by Marko Lindqvist almost 2 years ago
- Assignee set to Sveinung Kvilhaugsvik
- Sprint/Milestone changed from 2.6.4 to 2.6.5
Updated by Marko Lindqvist almost 2 years ago
Marko Lindqvist wrote:
Can Sveinung have a look of this issue in general?
Any progress?
Updated by Marko Lindqvist almost 2 years ago
- Sprint/Milestone changed from 2.6.5 to 2.6.6
Updated by Marko Lindqvist over 1 year ago
- Sprint/Milestone changed from 2.6.6 to 3.0.1
Updated by Marko Lindqvist 12 months ago
- Sprint/Milestone changed from 3.0.1 to 3.0.2
Updated by Marko Lindqvist 10 months ago
- Assignee deleted (
Sveinung Kvilhaugsvik) - Sprint/Milestone changed from 3.0.2 to 3.0.3
Updated by Marko Lindqvist 10 months ago
Can Alexandro have a look how all this works in current branches?
Updated by Alexandro Ignatiev 10 months ago
Marko Lindqvist wrote:
Can Alexandro have a look how all this works in current branches?
Could not reproduce the bug in 3.0. Likely, it's gone.
Updated by Marko Lindqvist 9 months ago
- Status changed from New to Closed
- Assignee set to Marko Lindqvist
Alexandro Ignatiev wrote:
Marko Lindqvist wrote:
Can Alexandro have a look how all this works in current branches?
Could not reproduce the bug in 3.0. Likely, it's gone.
Thanks.
Closing.
.