Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #885494

Remove dual activity meaning remains

Added by Sveinung Kvilhaugsvik almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The function can_unit_do_activity_targeted_at() had code that used to find out if an activity was extra creation or terrain transformation. It would then check if the appropriate action was enabled.

Terrain transformation and extra creation are now separate activities. This makes the old checks redundant. Remove them.

History

#1 Updated by Sveinung Kvilhaugsvik almost 2 years ago

#2 Updated by Marko Lindqvist almost 2 years ago

Sveinung Kvilhaugsvik wrote:

The function can_unit_do_activity_targeted_at() had code that used to find out if an activity was extra creation or terrain transformation. It would then check if the appropriate action was enabled.

The code you are removing did not select between actions. It checked if the target terrain supports selected activity.
I don't know if is_action_enabled_unit_on_tile() handles that check, meaning the checks you are removing were redundant.

#3 Updated by Sveinung Kvilhaugsvik almost 2 years ago

Marko Lindqvist wrote:

Sveinung Kvilhaugsvik wrote:

The function can_unit_do_activity_targeted_at() had code that used to find out if an activity was extra creation or terrain transformation. It would then check if the appropriate action was enabled.

The code you are removing did not select between actions. It checked if the target terrain supports selected activity.

Didn't it select between them before Feature #871737?

I don't know if is_action_enabled_unit_on_tile() handles that check, meaning the checks you are removing were redundant.

It is redundant.

#4 Updated by Sveinung Kvilhaugsvik almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF