Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #885765

Update and improve metaknowledge.c

Added by Alexandro Ignatiev almost 2 years ago. Updated 4 days ago.

Status:
New
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

10%

Estimated time:

Description

Many requirement types are not supported by functionality of this file. Probably we need a switch-based code here. Maybe some things need correction (e.g. "Building", "Local" req is set by the actor and is always knowable, is there such a building in the city, is not the business of this functionality). I'll supply some patch for 2.6 a bit later. In the newer versions, we should make more use of this module (for fair AI behaviour and some client-to-server requests).


Related issues

Related to Freeciv - Feature #922369: Metaknowledge for surviving tech requirementsClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Alexandro Ignatiev almost 2 years ago

This patch should be added to 2.6 version as a basic one for mine. It is not that important when the functionality is used for actions only and the actions are performed to seen cities, but in aphilosophical sence it's necessary.

#2 Updated by Alexandro Ignatiev almost 2 years ago

This is the main 2.6 patch, seems to work at my client. (I needed it for further server tweaks but maybe it won't be bad in the main branch.)

#3 Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.3 to 2.6.4

#4 Updated by Marko Lindqvist over 1 year ago

  • Assignee set to Sveinung Kvilhaugsvik

#5 Updated by Marko Lindqvist over 1 year ago

Any comment on this, Sveinung?

#6 Updated by Sveinung Kvilhaugsvik over 1 year ago

Marko Lindqvist wrote:

Any comment on this, Sveinung?

This was on my list of stuff that I either can do myself when I have a little limited time window for Freeciv or give as a "you are now good enough to do a real task in a real project" task to some friend I'm teaching C. I therefore didn't notice the attached patch when you assigned it to me.

Thank you for pointing it out, Marko. Sorry about the delay, Alexandro. I'll try to get it reviewed soon.

#7 Updated by Sveinung Kvilhaugsvik over 1 year ago

Overall impression is good.
Needs a rebase. (Sorry about the late review)
I suggest (but don't require) splitting out the different things you do in different patches. So moving is_effect_val_known() is in one patch, convertingn to switch is one, adding more meta knowledge another, etc. A good rule of thumb is that you start a sentence in the commit message with "Also" you should probably split the patch.

#8 Updated by Alexandro Ignatiev over 1 year ago

Hooh, splitting patches is not that fun as writing them... Well, let me try.

#9 Updated by Sveinung Kvilhaugsvik over 1 year ago

Alexandro Ignatiev wrote:

Hooh, splitting patches is not that fun as writing them...

Would the fact that you then will have more patches showing up under your name in OpenHub and GitHub help to motivate you?

Well, let me try.

You didn't upload anything yet, right? Just making sure that your new patch(es) hasn't been eaten by a bug.

#10 Updated by Alexandro Ignatiev over 1 year ago

Sveinung Kvilhaugsvik wrote:

You didn't upload anything yet, right? Just making sure that your new patch(es) hasn't been eaten by a bug.

Latest my patch on this topic was 6 months ago.

#11 Updated by Sveinung Kvilhaugsvik over 1 year ago

  • Related to Feature #922369: Metaknowledge for surviving tech requirements added

#12 Updated by Sveinung Kvilhaugsvik over 1 year ago

A correction to your current patch: Surviving tech reqs with the range "World" are visible to everyone. I added an explanation why in Feature #922369 I wished your clean up that changes stuff to use switch already had landed while I wrote it.

#13 Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.4 to 2.6.5

#14 Updated by Marko Lindqvist about 1 year ago

Any progress on this? We might go to code-freeze before 2.6.5 relatively soon (in a couple of weeks, not months)

#15 Updated by Marko Lindqvist about 1 year ago

  • Sprint/Milestone changed from 2.6.5 to 2.6.6

#16 Updated by Marko Lindqvist 8 months ago

  • Sprint/Milestone changed from 2.6.6 to 3.0.1

#17 Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone changed from 3.0.1 to 3.0.2

#18 Updated by Marko Lindqvist about 2 months ago

  • Sprint/Milestone changed from 3.0.2 to 3.0.3

#19 Updated by Marko Lindqvist 4 days ago

  • Sprint/Milestone changed from 3.0.3 to 3.0.4

Also available in: Atom PDF