HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Update and improve metaknowledge.c
Many requirement types are not supported by functionality of this file. Probably we need a
switch-based code here. Maybe some things need correction (e.g. "Building", "Local" req is set by the actor and is always knowable, is there such a building in the city, is not the business of this functionality). I'll supply some patch for 2.6 a bit later. In the newer versions, we should make more use of this module (for fair AI behaviour and some client-to-server requests).
#1 Updated by Alexandro Ignatiev almost 2 years ago
- File 0002-Backport-player_tile_city_id_get-interface-function.patch 0002-Backport-player_tile_city_id_get-interface-function.patch added
This patch should be added to 2.6 version as a basic one for mine. It is not that important when the functionality is used for actions only and the actions are performed to seen cities, but in aphilosophical sence it's necessary.
#6 Updated by Sveinung Kvilhaugsvik over 1 year ago
Marko Lindqvist wrote:
Any comment on this, Sveinung?
This was on my list of stuff that I either can do myself when I have a little limited time window for Freeciv or give as a "you are now good enough to do a real task in a real project" task to some friend I'm teaching C. I therefore didn't notice the attached patch when you assigned it to me.
Thank you for pointing it out, Marko. Sorry about the delay, Alexandro. I'll try to get it reviewed soon.
#7 Updated by Sveinung Kvilhaugsvik over 1 year ago
Overall impression is good.
Needs a rebase. (Sorry about the late review)
I suggest (but don't require) splitting out the different things you do in different patches. So moving is_effect_val_known() is in one patch, convertingn to switch is one, adding more meta knowledge another, etc. A good rule of thumb is that you start a sentence in the commit message with "Also" you should probably split the patch.
#9 Updated by Sveinung Kvilhaugsvik over 1 year ago
Alexandro Ignatiev wrote:
Hooh, splitting patches is not that fun as writing them...
Would the fact that you then will have more patches showing up under your name in OpenHub and GitHub help to motivate you?
Well, let me try.
You didn't upload anything yet, right? Just making sure that your new patch(es) hasn't been eaten by a bug.