Feature #892509: Make Qt-5.15 minimum requirement for --with-qt5x builds - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Feature #892509

Make Qt-5.15 minimum requirement for --with-qt5x builds

Added by Marko Lindqvist almost 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Bootstrap

Sprint/Milestone:

3.1.0

Start date:

Due date:

% Done:

Estimated time:

0029-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch (2.61 KB) 0029-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch		Marko Lindqvist, 2020-10-23 10:58 PM
0006-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch (2.37 KB) 0006-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch		Marko Lindqvist, 2020-10-30 06:00 PM

Related issues

History

#1 Updated by Marko Lindqvist almost 2 years ago

File 0029-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch 0029-Make-Qt-5.15-minimum-requirement-for-with-qt5x-build.patch added
Status changed from In Progress to Resolved

#2 Updated by Marko Lindqvist almost 2 years ago

Related to Feature #892507: Avoid using deprecated QLabel::pixmap() added

#3 Updated by Marko Lindqvist almost 2 years ago

There remains two deprecated constructs preventing making Qt-5.15 the minimum version. One is QLabel::pixmap() to be resolved with Feature #892507. That one needs to go in simultaneously (in same git push) as this minimum version bump.
The other is qrand() usage. In my current patch stack it gets resolved as a side effect of Bug #874406 fix. It should go in first.

#4 Updated by Marko Lindqvist almost 2 years ago

Blocked by Bug #874406: Trade plan calculation fails Qt 2.6.2 client added

#5 Updated by Marko Lindqvist almost 2 years ago

Marko Lindqvist wrote:

That one needs to go in simultaneously (in same git push)

Better way around this chicken and egg problem is to make this patch not to bump QT_DISABLE_DEPRECATED_BEFORE, but only to increase minimum Qt version. Then this can go in first without actually requiring changes to C++ code. Then C++ changes can go in, and finally a new separate ticket about bumping QT_DISABLE_DEPRECATED_BEFORE can go in.