Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #893403

Make duration of celebration effects consistent

Added by Marko Lindqvist almost 2 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Requested by graf wasili.

"the open question on what the correct duration is"


Related issues

Blocks Freeciv - Feature #892734: Rename city_celebrating() and friendsNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Feature #892727: Better reflect current celebration mechanics in client.In Progress

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist almost 2 years ago

#2 Updated by Marko Lindqvist almost 2 years ago

graf wasili:

Celebration effects currently have a different duration based on which
function they use to query this state.

The function base_city_celebrating() returns true if population
requirements for celebration are met now and happiness requirements have
been met
last turn. The function city_celebrating() additionally checks if the
happiness requirements still hold now.

This leads to the situation that wherever base_city_celebrating() is
used, celebration effects last one more turn if population requirements
are still met. Most notably this is true for tile outputs calculated by
city_tile_cache_update(). Rapture growth and the Lua-API are notable
examples of features that use city_celebrating() for checking
celebration state.

The question remains which behavior should be the base line for a
consistent implementation.

#3 Updated by Marko Lindqvist almost 2 years ago

  • Blocks Feature #892727: Better reflect current celebration mechanics in client. added

Also available in: Atom PDF