Help has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #893720

Make the gtk clients show who a player shares vision to

Added by Anonymous almost 2 years ago. Updated 9 days ago.

Start date:
Due date:
% Done:


Estimated time:


The server sends the info about which other players a player gives shared vision to along with the information on diplomatic relations. The Qt client shows it, but the GTK clients don't.

Add a simple note to indicate shared vision in the diplomatic relations list, so it'll show e.g. "Peace: James Gordon (receives vision)".


#1 Updated by Marko Lindqvist almost 2 years ago

- The new string should be marked for translation
- Master patch should include gtk-4.0 change (I'll test the compile (the only kind of test that we can do in gtk3x-client's current state) if you can't)

#2 Updated by Marko Lindqvist almost 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Anonymous
  • Sprint/Milestone set to 2.6.3

#4 Updated by Marko Lindqvist almost 2 years ago

- You are calling g_value_set_static_string() with string from a local buffer with limited lifetime.
g_value_set_static_string() documentation ( ) says: "The string is assumed to be static, and is thus not duplicated when setting the GValue." You may have garbage in that memory area by the time string is used.
- I think it would be better for translatability if you refactored so that you would have entire "%s (gives shared vision)" as one translatable string, so that translator have control over placing of the player name parameter. Probably required at least by the right-to-left written languages.

#5 Updated by Anonymous almost 2 years ago

Right, that's why I hate doing this kind of stuff in C.

Re. translations: I'm not exactly happy about the phrasing anyway. I would have just put some symbol or one-letter marker there (like the qt client does), but that would be a bit obfuscated without some additional text. And I don't have to much gtk experience to hack on that dialog any more than necessary.

#6 Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.3 to 2.6.4

This touches translatable strings, and string freeze for 2.6.3 has already begun.

#7 Updated by Marko Lindqvist over 1 year ago

  • Sprint/Milestone changed from 2.6.4 to 2.6.5

#8 Updated by Marko Lindqvist about 1 year ago

  • Sprint/Milestone changed from 2.6.5 to 2.6.6

#9 Updated by Marko Lindqvist 8 months ago

  • Sprint/Milestone changed from 2.6.6 to 3.0.1

#10 Updated by Marko Lindqvist 4 months ago

  • Status changed from In Progress to New
  • Sprint/Milestone changed from 3.0.1 to 3.0.2

#11 Updated by Marko Lindqvist 2 months ago

  • Category changed from Client to gui-gtk-3.22
  • Sprint/Milestone changed from 3.0.2 to 3.0.3

#12 Updated by Marko Lindqvist 9 days ago

  • Sprint/Milestone changed from 3.0.3 to 3.0.4

Also available in: Atom PDF