HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Make the gtk clients show who a player shares vision to
The server sends the info about which other players a player gives shared vision to along with the information on diplomatic relations. The Qt client shows it, but the GTK clients don't.
Add a simple note to indicate shared vision in the diplomatic relations list, so it'll show e.g. "Peace: James Gordon (receives vision)".
#3 Updated by Anonymous almost 2 years ago
- File 0001-Make-the-gtk-clients-show-who-a-player-shares-vision-S2_6.patch 0001-Make-the-gtk-clients-show-who-a-player-shares-vision-S2_6.patch added
- File 0001-Make-the-gtk-clients-show-who-a-player-shares-vision-master.patch 0001-Make-the-gtk-clients-show-who-a-player-shares-vision-master.patch added
Yep. I don't think I can even compile-test gtk4 but the function is exactly the same there, so maybe the same change will work...
#4 Updated by Marko Lindqvist almost 2 years ago
- You are calling g_value_set_static_string() with string from a local buffer with limited lifetime.
g_value_set_static_string() documentation ( https://developer.gnome.org/gobject/stable/gobject-Standard-Parameter-and-Value-Types.html#g-value-set-static-string ) says: "The string is assumed to be static, and is thus not duplicated when setting the GValue." You may have garbage in that memory area by the time string is used.
- I think it would be better for translatability if you refactored so that you would have entire "%s (gives shared vision)" as one translatable string, so that translator have control over placing of the player name parameter. Probably required at least by the right-to-left written languages.
#5 Updated by Anonymous almost 2 years ago
Right, that's why I hate doing this kind of stuff in C.
Re. translations: I'm not exactly happy about the phrasing anyway. I would have just put some symbol or one-letter marker there (like the qt client does), but that would be a bit obfuscated without some additional text. And I don't have to much gtk experience to hack on that dialog any more than necessary.