Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #901366

memory allocation size error in actions.c

Added by John Robertson over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
High
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

was

  struct ae_contra_or *out;
  ...
  out = fc_malloc(sizeof(out)); //alloc size = 8 (size of pointer)

should be

  struct ae_contra_or *out;
  ...
  out = fc_malloc(sizeof(*out));  //alloc size = 24 (size of structure)

History

#2 Updated by John Robertson over 1 year ago

This bug was crashing the freeciv-server.exe with memory writes past heap boundaries.

#3 Updated by Marko Lindqvist over 1 year ago

  • Category set to General
  • Status changed from New to Resolved
  • Assignee changed from John Robertson to Marko Lindqvist
  • Sprint/Milestone set to 3.1.0

#4 Updated by Marko Lindqvist over 1 year ago

I see this patch has different author name & email than your Feature #901393 patch. Is that intentional?

#5 Updated by John Robertson over 1 year ago

Not intentional, ... my local repositories on different computers have different git user settings. Both emails are mine. I'll watch this in the future to avoid confusion.

#6 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF