Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #903493

CI: Potentially incompatible versions of msys2 packages installed

Added by Marko Lindqvist over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

msys2 build on github actions fetches what ever is upstream's current version of msys2 packages. Those are not the same ones as what are supported by freeciv codebase (msys2 snapshot version as documented in doc/README.msys2), and will be incompatible from time to time (e.g., when there is update to such an dll that has version number included in the name - such as icu ones). Build will fail as it tries to find a file that does not exist (by the name it knows).

0009-CI-reenable-Windows-build.patch (1.71 KB) 0009-CI-reenable-Windows-build.patch Sveinung Kvilhaugsvik, 2021-01-30 05:49 PM
0001-CI-reenable-Windows-build.patch (1.87 KB) 0001-CI-reenable-Windows-build.patch Sveinung Kvilhaugsvik, 2021-02-02 09:13 AM

Related issues

Related to Freeciv - Feature #913235: Msys2: 'ci' target for the MakefileClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 1 year ago

#2 Updated by Sveinung Kvilhaugsvik over 1 year ago

Would setting a frozen msys2 version be considered a solution to this bug even if the list of snapshots to choose from is limited?

#3 Updated by Sveinung Kvilhaugsvik over 1 year ago

I think this matches the current msys2 version.

#4 Updated by Sveinung Kvilhaugsvik over 1 year ago

  • Category set to Bootstrap
  • Status changed from New to Resolved
  • Assignee set to Sveinung Kvilhaugsvik
  • Sprint/Milestone set to 3.1.0

Sveinung Kvilhaugsvik wrote:

I think this matches the current msys2 version.

20201109

#5 Updated by Sveinung Kvilhaugsvik over 1 year ago

Sveinung Kvilhaugsvik wrote:

Would setting a frozen msys2 version be considered a solution to this bug even if the list of snapshots to choose from is limited?

It looks like they update to new msys2 versions fairly regularly: https://github.com/msys2/setup-msys2/blob/master/CHANGELOG.md

#6 Updated by Marko Lindqvist over 1 year ago

Sveinung Kvilhaugsvik wrote:

Sveinung Kvilhaugsvik wrote:

Would setting a frozen msys2 version be considered a solution to this bug even if the list of snapshots to choose from is limited?

It looks like they update to new msys2 versions fairly regularly: https://github.com/msys2/setup-msys2/blob/master/CHANGELOG.md

Does this cover only msys2-base, or all the available packages, or something between?

#7 Updated by Sveinung Kvilhaugsvik over 1 year ago

Marko Lindqvist wrote:

Sveinung Kvilhaugsvik wrote:

Sveinung Kvilhaugsvik wrote:

Would setting a frozen msys2 version be considered a solution to this bug even if the list of snapshots to choose from is limited?

It looks like they update to new msys2 versions fairly regularly: https://github.com/msys2/setup-msys2/blob/master/CHANGELOG.md

Does this cover only msys2-base, or all the available packages, or something between?

I'm not familiar enough with msys2 to give you a 100% accurate answer. I think the answer to your question is that the version of the action corresponds to the version of base. There is a setting - update - to update the other packages to a more recent version than what came with base. https://github.com/msys2/setup-msys2#update My assumptions here about how msys2 works may be completely wrong.

I could reenable msys2 CI in a separate ticket if this doesn't fulfill your requirements for a solution to this bug.

#8 Updated by Sveinung Kvilhaugsvik over 1 year ago

Sveinung Kvilhaugsvik wrote:

I could reenable msys2 CI in a separate ticket if this doesn't fulfill your requirements for a solution to this bug.

Would you prefer that I did that or should I just land the patch from here?

#9 Updated by Marko Lindqvist over 1 year ago

Sveinung Kvilhaugsvik wrote:

Sveinung Kvilhaugsvik wrote:

I could reenable msys2 CI in a separate ticket if this doesn't fulfill your requirements for a solution to this bug.

Would you prefer that I did that or should I just land the patch from here?

It's not perfect, but we can live with it for now -> ok to close this ticket when the patch lands.

Could you document somewhere (comment in ci.yml?) where the mapping between snapshot dates and versions can be found, as we need to update that version every time we update the snapshot?

#10 Updated by Sveinung Kvilhaugsvik over 1 year ago

Marko Lindqvist wrote:

Could you document somewhere (comment in ci.yml?) where the mapping between snapshot dates and versions can be found, as we need to update that version every time we update the snapshot?

Done.

#11 Updated by Sveinung Kvilhaugsvik over 1 year ago

Marko Lindqvist wrote:

It's not perfect,

I agree.

#12 Updated by Sveinung Kvilhaugsvik over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF