Bug #913516: FIXED: Capture Units won't trigger Casus Belli - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Actions

Send by e-mail Copy link

Bug #913516

closed

FIXED: Capture Units won't trigger Casus Belli

Added by Lexxie L over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Server

Sprint/Milestone:

3.0.0-beta1

Start date:

Due date:

% Done:

Estimated time:

Description

unithand.c::do_capture_units(...)

line:360

/* May cause an incident */
    action_consequence_success(paction, pplayer,
                               unit_owner(to_capture),
                               pdesttile, victim_link);

This incorrectly identifies the victim as the owner. Because the unit has already been captured, unit_owner(to_capture) has now become the offender who captured the unit. This eventually causes action_consequence_success to fail in making casus belli.

FIX: change unit_owner(to_capture) to: uplayer

Files

0033-Fix-Capture-Unit-s-Casus-Belli-triggering.patch (945 Bytes) 0033-Fix-Capture-Unit-s-Casus-Belli-triggering.patch

Marko Lindqvist, 2021-01-07 02:07 PM