Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #921871

CI: OS X build broken

Added by Sveinung Kvilhaugsvik over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Immediate
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Homebrew has switched their qt packet to be Qt 6 by default. Ask for version 5.

0030-CI-Make-OSX-build-with-Qt6.patch (816 Bytes) 0030-CI-Make-OSX-build-with-Qt6.patch Marko Lindqvist, 2021-03-04 11:12 AM
0001-CI-fix-Mac-build.patch (1.45 KB) 0001-CI-fix-Mac-build.patch Sveinung Kvilhaugsvik, 2021-03-04 01:25 PM
0001-CI-Request-version-5-of-Qt-for-OSX-build.patch (1.7 KB) 0001-CI-Request-version-5-of-Qt-for-OSX-build.patch Marko Lindqvist, 2021-03-04 01:27 PM

Related issues

Related to Freeciv - Feature #892817: Bootstrap file changes for Qt6-clientClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 1 year ago

Alternatively we could configure it to make Qt6-client build, so that too would get tested on some CI setup. I would actually prefer that.

#2 Updated by Sveinung Kvilhaugsvik over 1 year ago

I may have been jumping to conclusions about what broke it.

#3 Updated by Marko Lindqvist over 1 year ago

(I don't see any failed build now. There was one Mac OSX build failed earlier, but it went through after retriggering)

#4 Updated by Sveinung Kvilhaugsvik over 1 year ago

Sveinung Kvilhaugsvik wrote:

I may have been jumping to conclusions about what broke it.

I investigated. Homebrew did - as I expected - just switch qt to Qt 6.

Marko Lindqvist wrote:

(I don't see any failed build now. There was one Mac OSX build failed earlier, but it went through after retriggering)

You will probably see it the next time you push. Example: https://github.com/kvilhaugsvik/freeciv/runs/2029853449?check_suite_focus=true

#5 Updated by Marko Lindqvist over 1 year ago

Then, does this patch work for master?

S3_1 is bit behind in Qt6 support, so requires more work.

#6 Updated by Marko Lindqvist over 1 year ago

#7 Updated by Marko Lindqvist over 1 year ago

Marko Lindqvist wrote:

Then, does this patch work for master?

I tried myself:

checking Qt6 headers... not found
configure: error: selected client 'qt' cannot be built: Missing Qt6 development files

#8 Updated by Sveinung Kvilhaugsvik over 1 year ago

  • Assignee deleted (Sveinung Kvilhaugsvik)

Marko Lindqvist wrote:

Then, does this patch work for master?

No, but it matches what I tried before I fell asleep so on the bright side your documentation for building with Qt 6 must be good.

#9 Updated by Marko Lindqvist over 1 year ago

Apparently it takes some effort to build OSX support for our Qt6-mode. So the issue here should be resolved by requesting Qt5 from Homebrew like you originally wrote.

#10 Updated by Sveinung Kvilhaugsvik over 1 year ago

#12 Updated by Sveinung Kvilhaugsvik over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee changed from Sveinung Kvilhaugsvik to Marko Lindqvist

Collision. The solution Marko committed worked. Thanks!

Also available in: Atom PDF