Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #922007

Give more space for unit type bonus value in the protocol

Added by Alexandro Ignatiev over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In packets.def, PACKET_RULESET_UNIT_BONUS has UINT8 type for value. That means, bonuses over 255 are wrongly sent to clients, and with the percentage bonuses we may often exceed this value. Increase it to at least UINT16.


Related issues

Blocks Freeciv - Feature #865084: Scramble combat bonusClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 1 year ago

#2 Updated by Alexandro Ignatiev over 1 year ago

I would even recommend SINT16 since we potentially may have negative bonuses in a ruleset, even though AI is yet bad at playing with them.

#4 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF