Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #923658

Savegame loading calls building_advisor() before AI flag set

Added by Marko Lindqvist over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When investigating Bug #857459 I found out that in savegame loading ba_human_wants() gets called for an AI players, or what eventually will be an AI player.


Related issues

Blocks Freeciv - Bug #857459: AIs never complete Wonders with too many save/restores (2.6.1+)Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 1 year ago

It actually wasn't before setting AI flag, but intentional switching the flag off for the building advisor run. Attached patch removes that code. Targeting to S3_1 and master only, as this is a bit risky change, and the old behavior is not that bad thing in older branches. The change is only needed in S3_1+ for the Bug #857459 fix to work.

#2 Updated by Marko Lindqvist over 1 year ago

  • Blocks Bug #857459: AIs never complete Wonders with too many save/restores (2.6.1+) added

#3 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF